Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1964 duplicate an archival objects record (was previously mislabeled as ANW-1757 duplicate a full resource record) #3185

Conversation

thimios
Copy link
Collaborator

@thimios thimios commented Apr 24, 2024

Description

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-1757

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@thimios thimios force-pushed the ANW-1757-As-an-archivist-I-would-like-an-option-to-duplicate-a-full-resource-record branch 8 times, most recently from ca173f9 to dcce075 Compare May 6, 2024 11:24
@thimios thimios force-pushed the ANW-1757-As-an-archivist-I-would-like-an-option-to-duplicate-a-full-resource-record branch from dcce075 to 89d79af Compare May 9, 2024 09:29
@thimios thimios marked this pull request as ready for review May 9, 2024 10:04
@thimios thimios requested review from brianzelip, lorawoodford and donaldjosephsmith and removed request for lorawoodford May 9, 2024 10:05
@@ -49,6 +49,27 @@
<% if AppConfig[:enable_public] %>
<%= render_aspace_partial :partial => "shared/view_published_button", :locals => {:record => record} %>
<% end %>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that this will conflict with the Softserv work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianzelip all conflicts resolved, this is ready for review!

@thimios thimios force-pushed the ANW-1757-As-an-archivist-I-would-like-an-option-to-duplicate-a-full-resource-record branch 2 times, most recently from 10b2b71 to 9510c47 Compare May 14, 2024 22:26
@thimios thimios force-pushed the ANW-1757-As-an-archivist-I-would-like-an-option-to-duplicate-a-full-resource-record branch from 9510c47 to 51d9a54 Compare May 23, 2024 15:31
@thimios thimios requested a review from brianzelip May 23, 2024 17:05
@brianzelip brianzelip merged commit 07165d6 into master May 23, 2024
20 checks passed
@brianzelip brianzelip deleted the ANW-1757-As-an-archivist-I-would-like-an-option-to-duplicate-a-full-resource-record branch May 23, 2024 18:26
@brianzelip
Copy link
Collaborator

brianzelip commented May 23, 2024

This PR was mis-labeled as ANW-1757 at the time of merging; it should have been labeled ANW-1964.

@brianzelip brianzelip changed the title ANW-1757 duplicate a full resource record ANW-1964 duplicate a full resource record (was previously mislabeled as ANW-1757) May 23, 2024
@brianzelip brianzelip changed the title ANW-1964 duplicate a full resource record (was previously mislabeled as ANW-1757) ANW-1964 duplicate an archival objects record (was previously mislabeled as ANW-1757 duplicate a full resource record) May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants