Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-363 Add search terms in context #3080

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stitching-coder
Copy link
Contributor

@stitching-coder stitching-coder commented Nov 26, 2023

Description

Public interface search results should show search terms in context. Highlighting from Solr has been turned on for this feature.

Related JIRA Ticket or GitHub Issue

ANW-363

How Has This Been Tested?

Some manual testing has been done.

Screenshots (if appropriate):

Screenshot 2023-11-26 at 6 05 31 PM Screenshot 2023-11-26 at 6 05 50 PM Screenshot 2023-11-26 at 6 06 14 PM Screenshot 2023-11-26 at 6 06 42 PM Screenshot 2023-11-26 at 6 06 54 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@stitching-coder stitching-coder marked this pull request as draft November 26, 2023 19:56
@brianzelip brianzelip requested review from brianzelip and removed request for brianzelip November 27, 2023 14:07
@stitching-coder stitching-coder changed the title Add search terms in context ANW-363 Add search terms in context Dec 16, 2023
@cdibella
Copy link
Contributor

cdibella commented May 9, 2024

According to @stitching-coder this works for items already on the search results page and in some other types of data that have been extracted, as seen in screenshot 1. It is not working when a result comes from related agents and subjects, as seen in screenshot 4. The highlighting also doesn't carry over for some types of results due to issues with creating the referring URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants