Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autodoc Python API reference #1176

Closed

Conversation

brenthuisman
Copy link
Contributor

@brenthuisman brenthuisman commented Oct 6, 2020

  • Added script doc/scripts/autodoc_cache.py. It generates doc/py_reference.rst if the Arbor Python package is importable.
    doc/py_reference.rst should be checked in, such that the Python API references will be generated
    even if arbor can't be imported (on RTD).
    On occasion, it should be updated by building the docs locally and git adding py_reference.rst.
  • Added doc/py_reference_generator.rst. It is required to cause autodoc to be run.

Provides a fix for #1172

  It generates `doc/py_reference.rst` if the Arbor Python package is importable.
  This file should be checked in, such that the Python API references will be generated
  even if `arbor` can't be imported (on RTD).
  On occasion, it should be updated.
* Added `doc/py_reference_generator.rst`. It is required to cause autodoc to be run.
@brenthuisman brenthuisman added documentation Documentation itself, or building and deployment of documentation. 0.4 labels Oct 6, 2020
@brenthuisman brenthuisman changed the title * Added script doc/scripts/autodoc_cache.py. Fix autodoc Python API reference Oct 6, 2020
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just not include automatically generated docs?

  • This is a big file, and I want to understand its impact on the size of the repository.
  • Every option like increases our surface area for bugs and issues building the docs

Let's stabilise the docs first, before adding more features like this.

@brenthuisman brenthuisman removed the 0.4 label Oct 7, 2020
@brenthuisman
Copy link
Contributor Author

No longer required, Arbor builds on RTD.

@brenthuisman brenthuisman deleted the fix_python_reference branch October 9, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation itself, or building and deployment of documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants