Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-forge and firebase-admin in /functions #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 10, 2023

Bumps node-forge to 1.3.1 and updates ancestor dependency firebase-admin. These dependencies need to be updated together.

Updates node-forge from 0.10.0 to 1.3.1

Changelog

Sourced from node-forge's changelog.

1.3.1 - 2022-03-29

Fixes

  • RFC 3447 and RFC 8017 allow for optional DigestAlgorithm NULL parameters for sha* algorithms and require NULL paramters for md2 and md5 algorithms.

1.3.0 - 2022-03-17

Security

  • Three RSA PKCS#1 v1.5 signature verification issues were reported by Moosa Yahyazadeh (moosa-yahyazadeh@uiowa.edu).
  • HIGH: Leniency in checking digestAlgorithm structure can lead to signature forgery.
  • HIGH: Failing to check tailing garbage bytes can lead to signature forgery.
  • MEDIUM: Leniency in checking type octet.
    • DigestInfo is not properly checked for proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.
    • CVE ID: CVE-2022-24773
    • GHSA ID: GHSA-2r2c-g63r-vccr

Fixed

  • [asn1] Add fallback to pretty print invalid UTF8 data.
  • [asn1] fromDer is now more strict and will default to ensuring all input bytes are parsed or throw an error. A new option parseAllBytes can disable this behavior.
    • NOTE: The previous behavior is being changed since it can lead to security issues with crafted inputs. It is possible that code doing custom DER parsing may need to adapt to this new behavior and optional flag.
  • [rsa] Add and use a validator to check for proper structure of parsed ASN.1

... (truncated)

Commits

Updates firebase-admin from 10.0.0 to 10.3.0

Release notes

Sourced from firebase-admin's releases.

Firebase Admin Node.js SDK v10.3.0

Bug Fixes

  • fix: Add type declarations to exports fields (#1758)
  • fix: Switch to @​fastify/busboy (#1757)

Miscellaneous

  • [chore] Release 10.3.0 (#1759)
  • build(deps): bump jwks-rsa from 2.1.0 to 2.1.4 (#1747)
  • build(deps-dev): bump @​microsoft/api-extractor from 7.24.2 to 7.25.0 (#1750)
  • build(deps-dev): bump @​firebase/app-compat from 0.1.25 to 0.1.26 (#1746)
  • build(deps-dev): bump @​typescript-eslint/parser from 5.25.0 to 5.27.1 (#1751)
  • build(deps-dev): bump ts-node from 10.8.0 to 10.8.1 (#1749)
  • build(deps): bump @​types/node from 17.0.38 to 17.0.41 (#1748)
  • build(deps-dev): bump eslint from 8.16.0 to 8.17.0 (#1745)
  • build(deps-dev): bump nock from 13.2.4 to 13.2.6 (#1744)
  • build(deps-dev): bump @​typescript-eslint/eslint-plugin (#1743)
  • build(deps-dev): bump @​firebase/auth-compat from 0.2.14 to 0.2.15 (#1735)
  • build(deps-dev): bump ts-node from 10.7.0 to 10.8.0 (#1737)
  • build(deps): bump @​types/node from 17.0.35 to 17.0.38 (#1736)
  • build(deps-dev): bump @​microsoft/api-extractor from 7.24.1 to 7.24.2 (#1734)
  • build(deps-dev): bump @​types/lodash from 4.14.178 to 4.14.182 (#1731)
  • build(deps-dev): bump del from 6.1.0 to 6.1.1 (#1725)
  • build(deps): bump @​types/node from 17.0.34 to 17.0.35 (#1720)
  • build(deps-dev): bump @​microsoft/api-extractor from 7.24.0 to 7.24.1 (#1721)
  • build(deps-dev): bump eslint from 8.15.0 to 8.16.0 (#1722)
  • build(deps-dev): bump @​typescript-eslint/eslint-plugin (#1719)
  • chore: Run nightly builds on Node 14 (#1717)
  • build(deps): bump @​types/node from 17.0.33 to 17.0.34 (#1716)
  • build(deps-dev): bump @​typescript-eslint/eslint-plugin (#1715)
  • build(deps-dev): bump @​microsoft/api-extractor from 7.23.2 to 7.24.0 (#1714)
  • build(deps-dev): bump yargs from 17.3.1 to 17.5.1 (#1711)
  • build(deps-dev): bump @​typescript-eslint/parser from 5.23.0 to 5.25.0 (#1713)
  • build(deps-dev): bump @​firebase/app-compat from 0.1.19 to 0.1.25 (#1709)
  • build(deps-dev): bump del from 6.0.0 to 6.1.0 (#1708)
  • build(deps): bump @​firebase/database-compat from 0.1.8 to 0.2.0 (#1706)
  • build(deps-dev): bump eslint from 8.14.0 to 8.15.0 (#1702)
  • build(deps-dev): bump @​firebase/auth-compat from 0.2.8 to 0.2.14 (#1701)
  • build(deps): bump @​types/node from 17.0.10 to 17.0.33 (#1700)
  • build(deps): bump @​firebase/database-types from 0.9.7 to 0.9.8 (#1699)
  • build(deps-dev): bump @​typescript-eslint/eslint-plugin (#1705)
  • build(deps-dev): bump @​microsoft/api-extractor from 7.19.4 to 7.23.2 (#1698)
  • build(deps-dev): bump @​types/chai-as-promised from 7.1.4 to 7.1.5 (#1697)
  • build(deps-dev): bump @​typescript-eslint/eslint-plugin (#1696)
  • build(deps-dev): bump @​typescript-eslint/parser from 5.12.0 to 5.23.0 (#1695)
  • build(deps-dev): bump sinon from 13.0.2 to 14.0.0 (#1692)
  • build(deps-dev): bump nock from 13.2.2 to 13.2.4 (#1691)
  • build(deps-dev): bump ts-node from 10.5.0 to 10.7.0 (#1690)
  • build(deps-dev): bump chai from 4.3.4 to 4.3.6 (#1689)

... (truncated)

Commits
  • ba2bb67 [chore] Release 10.3.0 (#1759)
  • f433953 fix: Add type declarations to exports fields (#1758)
  • f7ab421 fix: Switch to @​fastify/busboy (#1757)
  • dd50aaa build(deps): bump jwks-rsa from 2.1.0 to 2.1.4 (#1747)
  • bfb0423 build(deps-dev): bump @​microsoft/api-extractor from 7.24.2 to 7.25.0 (#1750)
  • e79ff74 build(deps-dev): bump @​firebase/app-compat from 0.1.25 to 0.1.26 (#1746)
  • 5dfcc0e build(deps-dev): bump @​typescript-eslint/parser from 5.25.0 to 5.27.1 (#1751)
  • 0e2736d build(deps-dev): bump ts-node from 10.8.0 to 10.8.1 (#1749)
  • 1f3183a build(deps): bump @​types/node from 17.0.38 to 17.0.41 (#1748)
  • 154f861 build(deps-dev): bump eslint from 8.16.0 to 8.17.0 (#1745)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [node-forge](https://github.com/digitalbazaar/forge) to 1.3.1 and updates ancestor dependency [firebase-admin](https://github.com/firebase/firebase-admin-node). These dependencies need to be updated together.


Updates `node-forge` from 0.10.0 to 1.3.1
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](digitalbazaar/forge@0.10.0...v1.3.1)

Updates `firebase-admin` from 10.0.0 to 10.3.0
- [Release notes](https://github.com/firebase/firebase-admin-node/releases)
- [Commits](firebase/firebase-admin-node@v10.0.0...v10.3.0)

---
updated-dependencies:
- dependency-name: node-forge
  dependency-type: indirect
- dependency-name: firebase-admin
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from aravindvnair99 as a code owner May 10, 2023 19:55
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 10, 2023
@guardrails
Copy link

guardrails bot commented May 10, 2023

⚠️ We detected 13 security issues in this pull request:

Vulnerable Libraries (13)
Severity Details
Medium bootstrap@3.3.5 upgrade to: >3.4.0
Medium jquery@1.11.3 upgrade to: >3.5.0
Critical ejs@3.1.6 upgrade to: >=3.1.7
Medium firebase-admin@10.3.0 upgrade to: >=11.8.0
Medium firebase-functions@3.16.0 upgrade to: >3.21.2
High google-gax@2.28.1 (t) upgrade to: >2.2.1-pre.2 || >2.30.4 || >3.0.1
Medium jose@2.0.5 (t) upgrade to: >2.0.5
High minimatch@3.0.4 (t) upgrade to: >=3.0.5
High node-fetch@2.6.6 (t) upgrade to: >=2.6.7
Medium pkg:npm/firebase-admin@10.3.0@2.0.5 (t) upgrade to: 4.9.2, 1.28.2, 3.20.4, 2.0.6
High pkg:npm/firebase-functions@3.16.0@4.18.2 (t) - no patch available
High pkg:npm/ejs@3.1.6@3.0.4 (t) upgrade to: 3.0.5
High pkg:npm/express@4.18.2@4.18.2 (t) - no patch available

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant