-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config class in trainer #574
Merged
thibaultdvx
merged 54 commits into
aramis-lab:refactoring
from
thibaultdvx:config_class_in_trainer
May 23, 2024
Merged
Config class in trainer #574
thibaultdvx
merged 54 commits into
aramis-lab:refactoring
from
thibaultdvx:config_class_in_trainer
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dvx/clinicadl into config_class_in_trainer
I just rebased @camillebrianceau, if it's ok for you I'll merge as soon as CI checks are ok |
camillebrianceau
approved these changes
May 23, 2024
camillebrianceau
pushed a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 23, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau
pushed a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 27, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau
pushed a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 29, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau
pushed a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 29, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau
pushed a commit
to camillebrianceau/clinicadl
that referenced
this pull request
May 30, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Training config classes:
BaseTaskConfig
to aTrainingConfig
class and puts it intrainer
folder.TrainingConfig
in several sub config classes.classification
,regression
andreconstruction
config classes inherit fromTrainingConfig
.Trainer:
Trainer
useTrainingConfig
.MAPSManager
and puts them inTrainer
.Random Search:
RandomSearchConfig
class.classification
andregression
config classes specific toRandom Search
(but they inherit from the baseclassification
andregression
classes).Random Search
config classes.CLI:
classification
,regression
,reconstruction
,from_json
,random-search
andresume
) to have something close to API mode and match modifications made inTrainer
.Organization:
tasks
folder totrainer
folder.Futur works:
Random Search
class to handle more easily the pipeline.resume
CLI/API.