Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config class in trainer #574

Merged

Conversation

thibaultdvx
Copy link
Collaborator

@thibaultdvx thibaultdvx commented May 16, 2024

Training config classes:

  • Changes BaseTaskConfig to a TrainingConfig class and puts it in trainer folder.
  • Splits TrainingConfig in several sub config classes.
  • Makes classification, regression and reconstruction config classes inherit from TrainingConfig.
  • Changes unittests to test those new config classes.

Trainer:

  • Makes the Trainer use TrainingConfig.
  • Removes some elements from MAPSManager and puts them in Trainer.

Random Search:

  • Creates a RandomSearchConfig class.
  • Makes classification and regression config classes specific to Random Search (but they inherit from the base classification and regression classes).
  • Makes unittests for Random Search config classes.

CLI:

  • Changes CLI options to connect them to those new config classes.
  • Changes CLI main functions (in classification, regression, reconstruction, from_json, random-search and resume) to have something close to API mode and match modifications made in Trainer.

Organization:

  • Moves some files from tasks folder to trainer folder.
  • Renames some files.

Futur works:

  • Create a Random Search class to handle more easily the pipeline.
  • Simplify resume CLI/API.

@thibaultdvx thibaultdvx added the refactoring ClinicaDL refactoring 2024 label May 16, 2024
@thibaultdvx
Copy link
Collaborator Author

I just rebased @camillebrianceau, if it's ok for you I'll merge as soon as CI checks are ok

@thibaultdvx thibaultdvx merged commit bb94468 into aramis-lab:refactoring May 23, 2024
13 checks passed
@thibaultdvx thibaultdvx deleted the config_class_in_trainer branch May 23, 2024 13:13
camillebrianceau pushed a commit to camillebrianceau/clinicadl that referenced this pull request May 23, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau pushed a commit to camillebrianceau/clinicadl that referenced this pull request May 27, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau pushed a commit to camillebrianceau/clinicadl that referenced this pull request May 29, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau pushed a commit to camillebrianceau/clinicadl that referenced this pull request May 29, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
camillebrianceau pushed a commit to camillebrianceau/clinicadl that referenced this pull request May 30, 2024
* use config classes in trainer and makes the appropriate changes in classification, regression, reconstruction, from_json, resume and random-search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring ClinicaDL refactoring 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants