feat: add support for arrays and pluralization to Trans component #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aralroca
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Thanks @acidfernando LGTM! thanks for you contribution
Please treat this as a first draft. We can discuss better ways of doing this.
I think using the formatElements as you did is the correct way! And it make sense to keep the same field returnObjects as the hook IMO. Great job
|
Thanks for your feedback! I'll let you merge when you think its appropriate |
|
@all-contributors please add @acidfernando for code |
|
I've put up a pull request to add @acidfernando! 🎉 |
|
@acidfernando available in 2.7.0-canary.1 |
aralroca
pushed a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Improved Trans component usability to allow dealing with array values and pluralization just as the hook does
Is there anything you'd like reviewers to focus on?
I'm not convinced by the new parameter
returnObjectsI added to Trans component. Its the same asuseTranslation.Please treat this as a first draft. We can discuss better ways of doing this. If it is a desired feature, I'm glad to keep working on it until we are all satisfied with the outcome.