Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use fs.WalkDir instead of filepath.WalkDir #6273

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Mar 5, 2024

Description

In fs walker, filepath.WalkDir is used when fs.WalkDir is used almost everywhere else.
There are subtle differences, for instance the root directory being a symlink, between
the 2 causing inconsistencies between the fs walk and deb post analyze walk.
This PR switches the fs walker to the newer fs.WalkDir interface.

Related issues

  • Close #XXX

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@lebauce lebauce changed the title Use fs.WalkDir instead of filepath.WalkDir feat: use fs.WalkDir instead of filepath.WalkDir Mar 5, 2024
@DmitriyLewen
Copy link
Contributor

Hello @lebauce
Thanks for your PR!

Looks like the tests are broken now.
Can you take a look?

Regards, Dmitriy

@lebauce
Copy link
Contributor Author

lebauce commented Mar 6, 2024

@DmitriyLewen Yes, sorry about that. Fixing the tests and putting it as "draft" until it's fixed

@lebauce lebauce marked this pull request as draft March 6, 2024 14:17
Copy link

github-actions bot commented May 6, 2024

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants