Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dart): use first version of constraint for dependencies using SDK version #6239

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(dart): use first version of constraint for dependencies using SDK version #6239

wants to merge 5 commits into from

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Mar 1, 2024 •
edited

Description

Use first version of constraint for dependencies using SDK version.
e.g. in this case the version of flutter_test should be 3.3.0:

  flutter_test:
    dependency: "direct dev"
    description: flutter
    source: sdk
    version: "0.0.0"
sdks:
  dart: ">=2.18.0 <3.0.0"
  flutter: "^3.3.0"

More information in #5984

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Mar 1, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review March 1, 2024 07:33
knqyf263
knqyf263 reviewed Mar 11, 2024
View reviewed changes
pkg/dependency/parser/dart/pub/parse.go Outdated
// We would like to exclude dev dependencies, but we cannot identify
// which indirect dependencies were introduced by dev dependencies
// as there are 3 dependency types, "direct main", "direct dev" and "transitive".
// It will be confusing if we exclude direct dev dependencies and include transitive dev dependencies.
// We decided to keep all dev dependencies until Pub will add support for "transitive main" and "transitive dev".
lib := types.Library{
ID: pkgID(name, dep.Version),
ID: utils.PackageID(name, dep.Version),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ID: utils.PackageID(name, dep.Version),
ID: utils.PackageID(name, version),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding my typo!
Fixed in c5ce4bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(dart): use minimum SDK version for packages that use SDK for package version
2 participants
@DmitriyLewen @knqyf263