New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secret): add line from dockerfile where secret was added to secret result #2780
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0b570bc
add lines from dockerfile to secrets
DmitriyLewen 91d7cef
refactor
DmitriyLewen ab8ea1a
refactor
DmitriyLewen 67c70da
add skip empty history
DmitriyLewen 70384d9
move createdby to layer
DmitriyLewen c0b43d2
add history for podman and containerd
DmitriyLewen 894c8c4
use diffId when wrong histories
DmitriyLewen f8c6387
Merge branch 'main' of github.com:aquasecurity/trivy into feat/docke…
DmitriyLewen 7a889eb
Merge branch 'main' into feat/dockerfile-line-for-secrets
knqyf263 1e073b2
refactor: separate a function
knqyf263 bc6837c
use v1.History
knqyf263 68d584b
remove cruft
knqyf263 be1bddc
do not show note when diff_id is empty
knqyf263 5817684
rpc: use reserved for deprecated fields
knqyf263 605c02e
fix a bug
knqyf263 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should compare
len(diffIDs)
andlen(createdBy)
. They should be the same. If they don't match, we should warn it. It is probably our bug.