feat(secret): Secret analyzer initialization using config object #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Aug 23, 2022
knqyf263
reviewed
Aug 30, 2022
| @@ -39,6 +39,7 @@ var ( | |||
|
|
|||
| type ScannerOption struct { | |||
| ConfigPath string | |||
| Config *secret.Config | |||
| } | |||
|
|
|||
| // SecretAnalyzer is an analyzer for secrets | |||
There was a problem hiding this comment.
I think we can just export scanner in SecretAnalyzer. You can initialize SecretAnalyzer with your scanner rather than calling RegisterSecretAnalyzer.
Moniseeta
added a commit
to Moniseeta/trivy
that referenced
this pull request
Sep 1, 2022
7 tasks
removed the config initialization with unit tests
|
In favor of #2835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Secret Analyzer initializes Scanner only via config file path only. This commit allows to initialize scanner if config is handy in memory
Related PRs
Remove this section if you don't have related PRs.
Checklist