Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): add function of using --file-patterns for terraform misconfiguration #2626

Closed
wants to merge 3 commits into from

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Jul 29, 2022

Description

Function is missing for Terraform misconfig.
Also update usage for --file-patterns to make it clear, by using this flag is to add extra file which matches patterns, default files are still in use.
Fix missing test cases :

  • dockerfile as name 'Containerfile'
  • terraform .tf.json

Ref: #2608 (not for fixing)

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zdtsw zdtsw force-pushed the zdtsw/feat_1 branch 2 times, most recently from 75a608a to f7fb6a4 Compare August 1, 2022 08:14
	- docs: make usage --file-patterns clear as it still includes default
files
	- test: add case for dockerfile as name 'Containerfile'
	- test: add case for terraform .tf.json
@jerbob92
Copy link
Contributor

jerbob92 commented Aug 9, 2022

Would be nice if we can get #2539 merged, which basically includes this functionality too.

@zdtsw
Copy link
Author

zdtsw commented Aug 22, 2022

I will have this one closed and leave the implementation to #2539

@zdtsw zdtsw closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants