update tests #334
Merged
update tests #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikpivkin looks like tests are red. Did you forget to push some changes? |
|
@simar7 Tests are red, because there are not yet copies of the images of the dbs and the checks bundle created |
simar7
reviewed
May 4, 2024
.github/workflows/sync-trivy-db.yaml
Outdated
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Copy Trivy Checks |
There was a problem hiding this comment.
Suggested change
| - name: Copy Trivy Checks | |
| - name: Copy Trivy DB |
simar7
reviewed
May 4, 2024
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Copy Trivy Checks |
There was a problem hiding this comment.
Suggested change
| - name: Copy Trivy Checks | |
| - name: Copy Trivy Java DB |
simar7
reviewed
May 4, 2024
Comment on lines
+16
to
+35
| function remove_json_fields() { | ||
| local file="$1" | ||
| if [[ "$file" == *.json ]]; then | ||
| jq 'del(.CreatedAt)' "$file" > tmp && mv tmp "$file" | ||
| fi | ||
| } | ||
|
|
||
| function remove_sarif_fields() { | ||
| local file="$1" | ||
| if [[ "$file" == *.sarif ]]; then | ||
| jq 'del(.runs[].tool.driver.version) | del(.runs[].originalUriBaseIds)' "$file" > tmp && mv tmp "$file" | ||
| fi | ||
| } | ||
|
|
||
| function remove_github_fields() { | ||
| local file="$1" | ||
| if [[ "$file" == *.gsbom ]]; then | ||
| jq 'del(.detector.version) | del(.scanned) | del(.job) | del(.ref) | del(.sha)' "$file" > tmp && mv tmp "$file" | ||
| fi | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests now uses a fixed version of db, java-db and a bundle of checks for data consistency.