Make 'hide-progress' input working again #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
simar7
requested changes
Mar 27, 2024
action.yaml
Outdated
| required: false | ||
| default: 'true' |
There was a problem hiding this comment.
This shouldn't be turned on by default as users expect to the see the output.
There was a problem hiding this comment.
Thanks for clearing this up, as there were discrepancies between the doc and the code.
Updated.
uridium
changed the title
simar7
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use this example, but Trivy is returning an error, when defining
hide-progress: falseorhide-progress: trueinput.This PR allows Trivy to use the correct
--quietflag, instead of non existing--no-progress.