Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): add --docker-host option for GH Action users #267

Merged
merged 3 commits into from Apr 3, 2024

Conversation

calinmarina
Copy link
Contributor

@calinmarina calinmarina commented Oct 10, 2023

This is addressing problem arising from trying to scan local images when docker socket path is different than default /var/run/docker.sock

This was already requested and solved here aquasecurity/trivy#2997 for CLI runs but not available for trivy GH Action.

Adds test and fixes outdated ones.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2023

CLA assistant check
All committers have signed the CLA.

@admiralAwkbar
Copy link
Contributor

@uridium

Would you be able to get this merged back to master?
Seems like an easy PR fix, and solves my issue in my current work as our docker-hosted runners mount on /run/docker/docker.sock

Thanks!

@uridium
Copy link
Contributor

uridium commented Apr 3, 2024

@admiralAwkbar it's not up to me, but @simar7

@simar7 simar7 self-requested a review April 3, 2024 23:25
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm! sorry about the delay in reviewing.

@simar7 simar7 merged commit 0f287db into aquasecurity:master Apr 3, 2024
1 of 2 checks passed
@admiralAwkbar admiralAwkbar mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants