Change github-pat input name #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuncanCasteleyn
suggested changes
Feb 20, 2023
| github-pat: | ||
| description: 'GitHub Personal Access Token (PAT) for submitting SBOM to GitHub Dependency Snapshot API' | ||
| github-token: | ||
| description: 'Authentication token to enable sending SBOM scan results to GitHub Dependency Graph. Can be either a GitHub Personal Access Token (PAT) or GITHUB_TOKEN' | ||
| required: false |
There was a problem hiding this comment.
Suggested change
| required: false | |
| default: ${{ github.token }} |
We could add this to make the configuration even simpler, not sure if that is a good idea, but it how it's done for https://github.com/actions/checkout/blob/main/action.yml for example.
There was a problem hiding this comment.
@simar7 do you think this should be part of the PR? Not part of the initial goals of the PR, but I think it is a good enough improvement to add.
|
guilherme_marz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Renames the
github-patinput argument togithub-token, as to better reflect the different kinds of tokens this input accepts, according to the changes made in #208.