v0.14.1 dependencies updates (security, ...) and an urfave quick fix #3067
Conversation
rafaeldtinoco
commented
May 8, 2023
rafaeldtinoco
commented
- tracee 0.14.0 should have updated packages but didn't because of an urfave issue. this is solved by this PR and the dependencies should be updated (security issues, etc).
rafaeldtinoco
changed the title
| @@ -49,6 +49,7 @@ func main() { | |||
|
|
|||
| return runner.Run(ctx) | |||
| }, | |||
| SliceFlagSeparator: " ", | |||
There was a problem hiding this comment.
needed to make the urfave to parse cmdline strings the same way it did
There was a problem hiding this comment.
From what I understand, the default separator for string slice is comma - so why don't we use it as is? We can simply remove the parsing we do for comma seperation ourseleves, can't we?
Also, from what I understand, we can simply disable the separation using
urfave/cli#1588 - maybe we should use that instead of a space separator?
There was a problem hiding this comment.
I'm not against to remove our own parsing in the future since we have both urfave and cobra parsers which can achieve that, but for this issue I consider SliceFlagSeparator enough.
There was a problem hiding this comment.
From what I understand, the default separator for string slice is comma - so why don't we use it as is? We can simply remove the parsing we do for comma seperation ourseleves, can't we?
we should do that after dropping urfave. For now we should use comma for both (after latest fix for cobra) and make sure command line is good, then we can change the parsing behavior (IMO).
| @@ -49,6 +49,7 @@ func main() { | |||
|
|
|||
| return runner.Run(ctx) | |||
| }, | |||
| SliceFlagSeparator: " ", | |||
There was a problem hiding this comment.
I'm not against to remove our own parsing in the future since we have both urfave and cobra parsers which can achieve that, but for this issue I consider SliceFlagSeparator enough.
