feat(schema): add database schema config #1129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
- Coverage 63.86% 63.26% -0.61%
==========================================
Files 12 12
Lines 1882 1900 +18
==========================================
Hits 1202 1202
- Misses 619 637 +18
Partials 61 61
Continue to review full report at Codecov.
|
mozillazg
reviewed
Mar 27, 2022
|
@luis-serra-ki Thanks for your contribution! |
mozillazg
requested changes
Mar 28, 2022
Co-authored-by: Huang Huang <mozillazg101@gmail.com>
chen-keinan
requested changes
Mar 29, 2022
Comment on lines
+61
to
+66
| if value := viper.GetString("PGSQL_SCHEMA"); value != "" { | ||
| schema = value | ||
| } else { | ||
| schema = "" | ||
| glog.V(2).Info("No schema set.") | ||
| } |
There was a problem hiding this comment.
Suggested change
| if value := viper.GetString("PGSQL_SCHEMA"); value != "" { | |
| schema = value | |
| } else { | |
| schema = "" | |
| glog.V(2).Info("No schema set.") | |
| } | |
| schema = viper.GetString("PGSQL_SCHEMA") |
| db, err := gorm.Open(postgres.Open(PsqlConnInfo.toString()), &gorm.Config{}) | ||
| var db *gorm.DB | ||
|
|
||
| if PsqlConnInfo.Schema == "" { |
There was a problem hiding this comment.
Suggested change
| if PsqlConnInfo.Schema == "" { | |
| if PsqlConnInfo.Schema == "" { | |
| glog.V(2).Info("No schema set.") |
|
@luis-serra-ki thank you for the contribution , added a couple of comments |
|
@serrovsky-pt Could you please take a look at these new comments? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this configuration, you can select database schema. This setting could be good when you want to share the same Postgres instance for different clusters validations.