[State Sync] Adopt state value iterator usage (main).

[JoshLind]

Description

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 253h 18m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
replay-mainnet / replay-verify (16)	11h 31m	🟩 🟩
rust-unit-coverage	11h 26m	🟩 🟩
replay-testnet / replay-verify (18)	11h 12m	🟩 🟩
replay-mainnet / replay-verify (15)	11h 7m	🟩 🟩
fullnode-execute-devnet-main / fullnode-sync	10h 1m	🟥 🟥
execution-performance / single-node-performance	9h 13m	🟩 🟩 🟩 🟥 🟥 (+10 more)
replay-testnet / replay-verify (16)	9h 10m	🟩 🟩
replay-mainnet / replay-verify (18)	9h	🟩 🟩
fullnode-fast-testnet-main / fullnode-sync	8h 18m	🟥 🟥 🟥 🟩 🟩 (+3 more)
fullnode-intelligent-devnet-main / fullnode-sync	8h 17m	🟩 🟩 🟩 🟩 🟩 (+4 more)
replay-mainnet / replay-verify (17)	7h 49m	🟩 🟩
replay-mainnet / replay-verify (12)	7h 47m	🟩 🟩
rust-smoke-coverage	7h 5m	🟥 🟥
replay-mainnet / replay-verify (11)	6h 57m	🟩 🟩
replay-testnet / replay-verify (9)	5h 43m	🟩 🟩
replay-testnet / replay-verify (10)	4h 56m	🟩 🟩
fullnode-execute-devnet-stable / fullnode-sync	4h 48m	🟩
replay-mainnet / replay-verify (10)	4h 43m	🟩 🟩
prover-inconsistency-test	4h 15m	🟥
run-forge-realistic-env-max-load-long / forge	4h 13m	🟩 🟩
replay-mainnet / replay-verify (14)	4h 5m	🟩 🟩
replay-testnet / replay-verify (8)	3h 59m	🟩 🟩
replay-mainnet / replay-verify (3)	3h 31m	🟩 🟩
replay-testnet / replay-verify (15)	3h 26m	🟩 🟩
replay-testnet / replay-verify (11)	3h 19m	🟩 🟩
replay-testnet / replay-verify (6)	2h 50m	🟩 🟩
replay-testnet / replay-verify (0)	2h 42m	🟩 🟩
replay-mainnet / replay-verify (6)	2h 36m	🟩 🟩
replay-testnet / replay-verify (12)	2h 35m	🟩 🟩
replay-mainnet / replay-verify (9)	2h 33m	🟩 🟩
fullnode-fast-testnet-stable / fullnode-sync	2h 30m	🟥 🟥
replay-testnet / replay-verify (2)	2h 22m	🟩 🟩
replay-mainnet / replay-verify (13)	2h 20m	🟩 🟩
replay-testnet / replay-verify (13)	2h 17m	🟩 🟩
run-forge-consensus-stress-test / forge	2h 14m	🟩 🟩 🟩
replay-mainnet / replay-verify (8)	2h 11m	🟩 🟩
replay-mainnet / replay-verify (7)	2h 8m	🟩 🟩
replay-testnet / replay-verify (1)	2h 8m	🟩 🟩
replay-testnet / replay-verify (17)	2h 5m	🟩 🟩
replay-testnet / replay-verify (14)	1h 57m	🟩 🟩
rust-smoke-tests	1h 55m	🟥 🟩 🟩
replay-testnet / replay-verify (4)	1h 53m	🟩 🟩
run-forge-fullnode-reboot-stress-test / forge	1h 47m	🟩 🟩 🟩
replay-testnet / replay-verify (5)	1h 46m	🟩 🟩
replay-testnet / replay-verify (7)	1h 42m	🟩 🟩
replay-mainnet / replay-verify (4)	1h 41m	🟩 🟩
replay-mainnet / replay-verify (5)	1h 37m	🟩 🟩
replay-testnet / replay-verify (3)	1h 36m	🟩 🟩
run-forge-pfn-const-tps-realistic-env / forge	1h 34m	🟩 🟩 🟩
run-forge-realistic-env-graceful-overload / forge	1h 31m	🟩 🟩 🟩
replay-mainnet / replay-verify (0)	1h 17m	🟩 🟩
fullnode-intelligent-mainnet-stable / fullnode-sync	1h 17m	🟩 🟩
replay-mainnet / replay-verify (2)	1h 16m	🟩 🟥 🟩
fullnode-fast-mainnet-main / fullnode-sync	1h 16m	🟩 🟩
fullnode-intelligent-testnet-main / fullnode-sync	1h 10m	🟥
run-forge-realistic-env-load-sweep / forge	1h 9m	🟩 🟩
run-forge-realistic-env-workload-sweep / forge	1h 6m	🟩 🟩
execution-performance / test-target-determinator	1h 4m	🟩 🟩 🟩 🟩 🟩 (+10 more)
run-forge-workload-mix-test / forge	1h 4m	🟩 🟩 🟩
run-forge-realistic-network-tuned-for-throughput / forge	1h 2m	🟩 🟩 🟩
run-forge-changing-working-quorum-test-high-load / forge	1h 1m	🟩 🟩 🟩
replay-mainnet / replay-verify (1)	55m	🟩 🟩
run-forge-changing-working-quorum-test / forge	52m	🟩 🟩 🟥
rust-images / rust-all	51m	🟩 ⬜ 🟩 🟩
run-forge-haproxy / forge	47m	🟥 🟩 🟥
forge-e2e-test / forge	41m	🟩 🟩 🟩
fullnode-fast-mainnet-stable / fullnode-sync	41m	🟩
run-forge-single-vfn-perf / forge	37m	🟩 🟩 🟩
fullnode-intelligent-mainnet-main / fullnode-sync	36m	🟩
forge-compat-test / forge	36m	🟩 🟩 🟩
run-forge-compat / forge	34m	🟩 🟩 🟩
rust-unit-tests	33m	🟩
rust-targeted-unit-tests	30m	🟥 🟥 🟩
run-forge-framework-upgrade-test / forge	30m	🟩 🟩
rust-images-performance / rust-all	29m	🟩
rust-lints	22m	🟩 🟩 🟩
cli-e2e-tests / run-cli-tests	21m	🟩 🟩 🟥
semgrep/ci	20m	🟩 🟩 🟩 🟩 🟩 (+48 more)
rust-images-failpoints / rust-all	17m	🟩
run-indexer-grpc-in-memory-cache-benchmark	16m	🟥 🟥
rust-build-cached-packages	16m	🟩 🟩 🟩
run-tests-main-branch	12m	🟩 🟩 🟩
test-target-determinator	11m	🟩 ⬜ 🟩 🟩
check	8m	🟩 ⬜ 🟩
rust-move-tests	6m	⬜ 🟩 ⬜ 🟩
general-lints	6m	🟩 🟩 🟩
check-dynamic-deps	5m	🟩 🟩 🟩 🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose	3m	🟩 🟥
determine-test-metadata	3m	🟩 🟩
build	3m	🟥
node-api-compatibility-tests / node-api-compatibility-tests	2m	🟩 🟩 🟩
copy-images-to-dockerhub / copy-images	2m	🟩 🟩
check-repo	2m	🟩 🟩 🟩 🟩 🟩 (+4 more)
prune	58s	🟩 🟩 🟩
check-repo	55s	🟩 🟩 🟩 🟩 🟩
copy-images-to-docker-hub / copy-images	55s	🟩
linkChecker	44s	🟥 🟥
file_change_determinator	37s	🟩 🟩 🟩 🟩
file_change_determinator	35s	🟩 🟩 🟩
update	35s	🟩
file_change_determinator	31s	⬜ 🟩 🟩 🟩
stale	25s	🟩 🟩
check-repo	24s	🟩 🟩
check-repo	23s	🟩 🟩
check-repo	22s	🟩 🟩
upload-to-codecov	22s	🟥 🟥
check-repo	21s	🟩 🟩
check-repo	21s	🟩 🟩
permission-check	15s	🟩 🟩 🟩 🟩 🟩
permission-check	14s	🟩 🟩 🟩 🟩 🟩
determine-test-metadata	14s	🟩 🟩
permission-check	13s	🟩 🟩 🟩 🟩
check-repo	12s	🟩
forge-framework-upgrade-test / forge	12s	🟩
check-repo	10s	🟩
check-repo	10s	🟩
check-repo	10s	🟩
permission-check	9s	🟩 🟩 🟩 🟩
determine-docker-build-metadata	9s	🟩 🟩 🟩 🟩
permission-check	9s	🟩 🟩 🟩 🟩

🚨 8 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	42m	22m
rust-lints	11m	6m
rust-build-cached-packages	8m	5m
rust-images / rust-all	18m	13m
cli-e2e-tests / run-cli-tests	9m	7m
rust-targeted-unit-tests	7m	18m
rust-move-tests	3m	11m
forge-framework-upgrade-test / forge	12s	1h 1m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 32f7e3cdc3d88275ba5d79b5a797a10b6cc188bb

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 32f7e3cdc3d88275ba5d79b5a797a10b6cc188bb (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6563.864450704004 txn/s, latency: 4719.168269078216 ms, (p50: 4800 ms, p90: 5100 ms, p99: 8100 ms), latency samples: 252120
2. Upgrading first Validator to new version: 32f7e3cdc3d88275ba5d79b5a797a10b6cc188bb
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1838.4067678161969 txn/s, latency: 15526.244317439581 ms, (p50: 19100 ms, p90: 21900 ms, p99: 22400 ms), latency samples: 91860
3. Upgrading rest of first batch to new version: 32f7e3cdc3d88275ba5d79b5a797a10b6cc188bb
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1848.106768662871 txn/s, latency: 15453.687988705473 ms, (p50: 18900 ms, p90: 21700 ms, p99: 22300 ms), latency samples: 92080
4. upgrading second batch to new version: 32f7e3cdc3d88275ba5d79b5a797a10b6cc188bb
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3441.7507601788616 txn/s, latency: 9063.701719197708 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12800 ms), latency samples: 139600
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 32f7e3cdc3d88275ba5d79b5a797a10b6cc188bb passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 32f7e3cdc3d88275ba5d79b5a797a10b6cc188bb

two traffics test: inner traffic : committed: 8199.972177921012 txn/s, latency: 4782.577318626426 ms, (p50: 4500 ms, p90: 5600 ms, p99: 10800 ms), latency samples: 3539380
two traffics test : committed: 100.08348761480659 txn/s, latency: 1979.807471264368 ms, (p50: 1800 ms, p90: 2100 ms, p99: 7700 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.203, avg: 0.201", "QsPosToProposal: max: 0.240, avg: 0.217", "ConsensusProposalToOrdered: max: 0.439, avg: 0.399", "ConsensusOrderedToCommit: max: 0.358, avg: 0.347", "ConsensusProposalToCommit: max: 0.754, avg: 0.746"]
Max round gap was 1 [limit 4] at version 1765527. Max no progress secs was 4.837617 [limit 15] at version 1765527.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking