Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testnet] migration proposal #13309

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

lightmark
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 16, 2024

⏱️ 2h 32m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 55m 🟩🟩🟩
execution-performance / single-node-performance 25m 🟩
rust-move-tests 24m 🟩🟩🟩
rust-lints 17m 🟩🟩🟩
run-tests-main-branch 17m 🟩🟩🟩🟩
general-lints 6m 🟩🟩🟩
check-dynamic-deps 5m 🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 43s 🟩🟩🟩🟩
file_change_determinator 42s 🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩
permission-check 9s 🟩🟩🟩🟩
permission-check 9s 🟩🟩🟩🟩
permission-check 9s 🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@lightmark lightmark force-pushed the lightmark/migration_proposal branch from 46e098c to 85b3b9f Compare May 16, 2024 21:57
@sherry-x
Copy link
Contributor

you need to have this on 1.12 branch

@lightmark lightmark marked this pull request as draft May 16, 2024 22:29
@lightmark lightmark force-pushed the lightmark/migration_proposal branch from b326f49 to eebd47e Compare May 16, 2024 23:00
@sherry-x sherry-x marked this pull request as ready for review June 5, 2024 16:40
@sherry-x sherry-x force-pushed the lightmark/migration_proposal branch from eebd47e to 5bb4bcc Compare June 5, 2024 16:40
@sherry-x sherry-x enabled auto-merge (squash) June 5, 2024 16:40
@lightmark lightmark force-pushed the lightmark/migration_proposal branch from 5bb4bcc to 9826fc6 Compare June 5, 2024 16:52

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sherry-x sherry-x force-pushed the lightmark/migration_proposal branch from 9826fc6 to 675723b Compare June 5, 2024 17:26
@lightmark lightmark force-pushed the lightmark/migration_proposal branch from 675723b to a3199f0 Compare June 5, 2024 17:31

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@lightmark lightmark force-pushed the lightmark/migration_proposal branch from a3199f0 to 6736c1f Compare June 5, 2024 19:13

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> 6736c1f166a02e50c9089875b74422ed048f1f4e

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 6736c1f166a02e50c9089875b74422ed048f1f4e (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6884 txn/s, latency: 4837 ms, (p50: 4800 ms, p90: 8100 ms, p99: 8700 ms), latency samples: 240940
2. Upgrading first Validator to new version: 6736c1f166a02e50c9089875b74422ed048f1f4e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2779 txn/s, latency: 10825 ms, (p50: 9600 ms, p90: 20300 ms, p99: 20800 ms), latency samples: 108400
3. Upgrading rest of first batch to new version: 6736c1f166a02e50c9089875b74422ed048f1f4e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3047 txn/s, latency: 9218 ms, (p50: 9900 ms, p90: 13300 ms, p99: 15000 ms), latency samples: 137120
4. upgrading second batch to new version: 6736c1f166a02e50c9089875b74422ed048f1f4e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6361 txn/s, latency: 5235 ms, (p50: 4900 ms, p90: 8400 ms, p99: 9600 ms), latency samples: 235360
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> 6736c1f166a02e50c9089875b74422ed048f1f4e passed
Test Ok

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ Forge suite realistic_env_max_load success on 6736c1f166a02e50c9089875b74422ed048f1f4e

two traffics test: inner traffic : committed: 7955 txn/s, latency: 4931 ms, (p50: 4800 ms, p90: 6000 ms, p99: 10800 ms), latency samples: 3436680
two traffics test : committed: 100 txn/s, latency: 2036 ms, (p50: 1800 ms, p90: 2200 ms, p99: 7500 ms), latency samples: 1760
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.219, avg: 0.206", "QsPosToProposal: max: 0.272, avg: 0.242", "ConsensusProposalToOrdered: max: 0.438, avg: 0.390", "ConsensusOrderedToCommit: max: 0.388, avg: 0.370", "ConsensusProposalToCommit: max: 0.773, avg: 0.761"]
Max round gap was 1 [limit 4] at version 989752. Max no progress secs was 5.192331 [limit 15] at version 989752.
Test Ok

@sherry-x sherry-x disabled auto-merge June 5, 2024 20:01
@sherry-x sherry-x merged commit 5b5c1b9 into aptos-release-v1.12 Jun 5, 2024
45 of 50 checks passed
@sherry-x sherry-x deleted the lightmark/migration_proposal branch June 5, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants