Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CONCURRENT_FUNGIBLE_ASSET_SUPPLY by default #13295

Closed
wants to merge 2 commits into from

Conversation

igor-aptos
Copy link
Contributor

devnet should have it enabled by default.

extracting from not-yet-reviewed #13194

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented May 16, 2024

⏱️ 14h 36m total CI duration on this PR
Job Cumulative Duration Recent Runs
forge-framework-upgrade-test / forge 2h 35m 🟥🟩
windows-build 2h 2m 🟩🟩🟩
rust-targeted-unit-tests 1h 43m 🟥🟩🟩🟩
rust-smoke-tests 1h 8m 🟥🟩🟩
rust-move-tests 1h 5m 🟩🟩🟩🟩🟩
execution-performance / single-node-performance 52m 🟥🟩🟥
forge-e2e-test / forge 49m 🟥🟩🟩
rust-move-unit-coverage 47m 🟥🟥🟩🟩
forge-compat-test / forge 41m 🟩🟩
rust-images / rust-all 38m 🟩🟩🟩
rust-lints 26m 🟥🟥🟥🟩🟩
run-tests-main-branch 22m 🟩🟩🟩🟩🟩
cli-e2e-tests / run-cli-tests 19m 🟩🟩🟩
rust-build-cached-packages 14m 🟥🟩🟩
check 12m 🟩🟩🟩
test-target-determinator 10m 🟩🟩🟩
general-lints 10m 🟩🟩🟩🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 3m 🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 1m 🟩🟩🟩🟩🟩
file_change_determinator 51s 🟩🟩🟩🟩🟩
file_change_determinator 30s 🟩🟩🟩
permission-check 22s 🟩🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩🟩
permission-check 10s 🟩🟩🟩🟩🟩
determine-docker-build-metadata 9s 🟩🟩🟩
permission-check 7s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-build-cached-packages 4m 5m -23%

settingsfeedbackdocs ⋅ learn more about trunk.io

@igor-aptos igor-aptos force-pushed the igor/enable_fungible_asset_supply branch from 00a09fe to 91e3303 Compare May 16, 2024 07:15
@sherry-x sherry-x enabled auto-merge (squash) May 16, 2024 16:19

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/enable_fungible_asset_supply branch from 91e3303 to 9f90f2b Compare May 16, 2024 16:45

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5%. Comparing base (55a02a2) to head (edb77fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13295   +/-   ##
=======================================
  Coverage    57.5%    57.5%           
=======================================
  Files         832      832           
  Lines      198564   198564           
=======================================
  Hits       114269   114269           
  Misses      84295    84295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> edb77fb6440d9b7d4f47fd7cc2de685b80b788d1

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> edb77fb6440d9b7d4f47fd7cc2de685b80b788d1 (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6816.55857570572 txn/s, latency: 4848.694098494098 ms, (p50: 4800 ms, p90: 8100 ms, p99: 8700 ms), latency samples: 245700
2. Upgrading first Validator to new version: edb77fb6440d9b7d4f47fd7cc2de685b80b788d1
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1757.521252620061 txn/s, latency: 16275.863788426763 ms, (p50: 19800 ms, p90: 24100 ms, p99: 24400 ms), latency samples: 88480
3. Upgrading rest of first batch to new version: edb77fb6440d9b7d4f47fd7cc2de685b80b788d1
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1681.4927367154592 txn/s, latency: 16607.98660634495 ms, (p50: 18900 ms, p90: 22500 ms, p99: 23100 ms), latency samples: 89520
4. upgrading second batch to new version: edb77fb6440d9b7d4f47fd7cc2de685b80b788d1
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1692.4981475501381 txn/s, latency: 17217.912993680886 ms, (p50: 18600 ms, p90: 25300 ms, p99: 28300 ms), latency samples: 75960
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> edb77fb6440d9b7d4f47fd7cc2de685b80b788d1 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on edb77fb6440d9b7d4f47fd7cc2de685b80b788d1

two traffics test: inner traffic : committed: 7970.41075428657 txn/s, latency: 4914.871856845209 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10500 ms), latency samples: 3446060
two traffics test : committed: 100.03957072446087 txn/s, latency: 1889.7786516853932 ms, (p50: 1800 ms, p90: 2100 ms, p99: 2800 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.208, avg: 0.205", "QsPosToProposal: max: 0.263, avg: 0.220", "ConsensusProposalToOrdered: max: 0.468, avg: 0.427", "ConsensusOrderedToCommit: max: 0.416, avg: 0.392", "ConsensusProposalToCommit: max: 0.832, avg: 0.819"]
Max round gap was 1 [limit 4] at version 1632763. Max no progress secs was 4.789489 [limit 15] at version 1632763.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> edb77fb6440d9b7d4f47fd7cc2de685b80b788d1

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> edb77fb6440d9b7d4f47fd7cc2de685b80b788d1 (PR)
Upgrade the nodes to version: edb77fb6440d9b7d4f47fd7cc2de685b80b788d1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 956.9224725909967 txn/s, submitted: 958.7015522518677 txn/s, failed submission: 1.779079660871014 txn/s, expired: 1.779079660871014 txn/s, latency: 3105.5883453404604 ms, (p50: 2400 ms, p90: 5400 ms, p99: 10100 ms), latency samples: 86060
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1105.559452254848 txn/s, submitted: 1107.6067845738387 txn/s, failed submission: 2.0473323189904598 txn/s, expired: 2.0473323189904598 txn/s, latency: 2850.5233230452677 ms, (p50: 2400 ms, p90: 5100 ms, p99: 9300 ms), latency samples: 97200
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> edb77fb6440d9b7d4f47fd7cc2de685b80b788d1 passed
Upgrade the remaining nodes to version: edb77fb6440d9b7d4f47fd7cc2de685b80b788d1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1093.5271573136931 txn/s, submitted: 1095.3324023113219 txn/s, failed submission: 1.8052449976288785 txn/s, expired: 1.8052449976288785 txn/s, latency: 2859.7638567891045 ms, (p50: 2100 ms, p90: 5600 ms, p99: 9200 ms), latency samples: 96920
Test Ok

@igor-aptos igor-aptos closed this May 28, 2024
auto-merge was automatically disabled May 28, 2024 21:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants