Improve test and abort safety with is_stack_unbiasable() check #13291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 3h 31m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
alinush
approved these changes
May 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13291 +/- ##
=========================================
- Coverage 57.6% 57.5% -0.1%
=========================================
Files 834 834
Lines 198396 198584 +188
=========================================
+ Hits 114325 114345 +20
- Misses 84071 84239 +168 ☔ View full report in Codecov by Sentry. |
igor-aptos
commented
May 15, 2024
Comment on lines
+62
to
+69
| if context.gas_feature_version() >= RELEASE_V1_13 { | ||
| context.charge(RANDOMNESS_FETCH_AND_INCREMENT_BASE)?; | ||
| } |
There was a problem hiding this comment.
@vgao1996 - should every native function charge some base gas, or if function is simple enough - charging of native call is enough?
i.e. randomness had no gas charging before, so I added it here. not sure if that is needed
|
|
||
| if context.gas_feature_version() >= RELEASE_V1_13 { | ||
| context | ||
| .charge(RANDOMNESS_UNBIASABLE_CHECK_PER_STACK * NumArgs::new(visited))?; |
There was a problem hiding this comment.
is PerArg/NumArgs the best thing to use for per_count gas charge?
igor-aptos
force-pushed
the
igor/improve_test_and_abort_safety
branch
from
da544d8
to
7c4ccd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement safety measure as described in the AIP.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist