Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sylabs/sif v2.15.2 #228

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Update to sylabs/sif v2.15.2 #228

merged 2 commits into from
Mar 11, 2024

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Mar 11, 2024

This updates to the sylabs/sif v2.15.2 by pulling in

the latter of which had a PR description of

revive linter now checks for this as of v1.3.7.

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
revive linter now checks for this as of v1.3.7.

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.23%. Comparing base (8eb8c31) to head (1cf9c09).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/siftool/siftool.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files          34       34           
  Lines        3268     3268           
=======================================
  Hits         2132     2132           
  Misses        980      980           
  Partials      156      156           
Flag Coverage Δ
unittests 65.23% <88.88%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrDaveD DrDaveD merged commit 425b739 into apptainer:main Mar 11, 2024
2 checks passed
@DrDaveD DrDaveD deleted the sylabsv2.15.2 branch March 11, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants