#213 Fix bug with {fmt} integration #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I made a commit before reading about Arlo git notation. I can modify its message if needed |
|
Thank you very much indeed for this. We are currently trying to get the builds passing again, after which we will test, review and merge this. |
|
Any progress? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be small
Small pull requests are great and easy for me to understand and accept
Please try prefix every commits in the pull request with Arlo's git notation
But it's not small!
Then you should setup a remote pairing session with Llewellyn ( llewellyn.falco@gmail.com )
Usually the sessions are between 45-90 minutes.
assuming you still feel it is small, please include
Description
See linked issue #213.
TL;DR
{fmt}integration is triggered by FMT_VERSION define that is provided by<fmt/core.h>, while feature itself is usingfmt::to_string()that is defined in<fmt/format.h>that causes a bug.The solution
Include
<fmt/format.h>in case{fmt}integration is triggered, so even if user included only<fmt/core.h>, the library provides itself with needed header to work correctly.Notation
I prefer lots of very small commits prefixed with Arlo's git notation