Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop SerializableTheory #763

Merged
merged 1 commit into from Jan 23, 2024
Merged

drop SerializableTheory #763

merged 1 commit into from Jan 23, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp SimonCropp added this to the 7.0.0 milestone Jan 23, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: The pull request removes the 'SerializableTheory.cs' file from the 'ApprovalTests/TheoryTests' directory, indicating a cleanup or deprecation of the associated functionality.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Files deleted: Sourcery does not currently approve diffs with deleted files.

General suggestions:

  • Ensure that the removal of 'SerializableTheory.cs' does not affect any dependent code or tests. If there are dependencies, they should be refactored or removed accordingly.
  • Consider providing a brief description in the PR to explain the context behind the deletion, such as the reasons for deprecating the file and if this change is part of a larger refactoring effort.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@SimonCropp SimonCropp merged commit 9c30064 into master Jan 23, 2024
1 of 3 checks passed
@SimonCropp SimonCropp deleted the drop-SerializableTheory branch January 23, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant