Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update supported frameworks #759

Merged
merged 1 commit into from Jan 22, 2024
Merged

Conversation

SimonCropp
Copy link
Contributor

Old minimum supported frameworks

  • net462
  • netstandard2.0
  • net5.0

New

  • net472
  • net6.0

@SimonCropp SimonCropp added this to the 7.0.0 milestone Jan 22, 2024
@SimonCropp SimonCropp merged commit 1f3bdac into master Jan 22, 2024
1 of 3 checks passed
@SimonCropp SimonCropp deleted the update-supported-frameworks branch January 22, 2024 23:39
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request updates the project to support newer versions of .NET frameworks, specifically moving from .NET Framework 4.6.2 and .NET 5.0 to .NET Framework 4.7.2 and .NET 6.0. This change ensures compatibility with the latest features and optimizations provided by these frameworks and potentially drops support for older, less secure, or less efficient versions.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that all dependencies of the project are also compatible with the new framework versions to prevent any compatibility issues.
  • Consider updating the documentation and any CI/CD pipelines to reflect the changes in supported frameworks.
  • Verify that the major version bump is communicated to users, as this change may introduce breaking changes for consumers of the library.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant