Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in IApprovalApprover description #751

Merged
merged 1 commit into from May 11, 2024

Conversation

askazakov
Copy link
Contributor

Description

fix typo that misleads about call to Approve() and Fail()

Fail() actually invoked only if Approve() returns false

@askazakov
Copy link
Contributor Author

askazakov commented Nov 17, 2023

probably the whole comment should be rewritten because actual logic a little more complicated then just

if (!Approve()) {
 Fail()
}

@askazakov askazakov changed the title fix typo fix typo in IApprovalApprover description Nov 17, 2023
@SimonCropp SimonCropp merged commit 757382b into approvals:master May 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants