Update dependencies. Requires go 1.18 and BasicLimiter -> ScalingLimitConfig #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not |
neelvirdy
force-pushed
the
nvirdy/update-dependencies
branch
from
d3c18d5
to
53ab4c1
Compare
en0ma
previously approved these changes
Nov 15, 2022
alvin-reyes
reviewed
Nov 15, 2022
alvin-reyes
reviewed
Nov 15, 2022
alvin-reyes
previously approved these changes
Nov 15, 2022
There was a problem hiding this comment.
I ran the build on my local and executed a few regression tests and this seems to work as expected. I have a few minimal feedback but mostly nits. Great work on adding more assertions.
One thing I'm concerned with this update is if it's somehow impacts Graphsync and/or boost transfers. It shouldn't but it be good to test it.
Let's just merge this to dev and see if we can test those out. If it's ok, maybe let's run some graphsync and boost transfers with this bumps? It would be interested to know if this somehow impacts AR/filclient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quic-go dropped support for go 1.17 in 0.29.0 so we have to require go 1.18 moving forward.
libp2p's rcmgr lib did a migration from BasicLimiter to ScalingLimitConfig in 0.21.0. This hardly effects us since we run with the NoLimiter flag set to true, so we dont even go down the impacted code path. But the migration is done and tested in case we switch. If we have any json-loading of the Node config struct we will need to adapt that wherever that lives to fit ScalingLimitConfig's schema.
Next blocker for getting to latest is filclient: https://github.com/application-research/filclient/blob/master/go.mod#L39-L41. Will track a follow-up to get filclient updated and then continue updating estuary.