fix: Enforce usage of Base64 compliant with RFC 4648 for all operations #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Oct 27, 2022
SrinivasanTarget
approved these changes
Oct 27, 2022
valfirst
deleted the
enforce-usage-of-base64-rfc-4648-for-all-operations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Enforce usage of Base64 encoding scheme compliant with
RFC 4648for all operations (instead ofRFC 2045).Types of changes
What types of changes are you proposing/introducing to Java client?
Details
I'm not sure whether it's really necessary. However the wave of conversations around encoding of screenshots makes me think that following single standard (W3C WebDriver spec sticks to
RFC 4648) for all operations will be more consistent approach.