Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignores inside functions for declaration-property-unit-allowed-list #5

Merged
merged 1 commit into from Apr 20, 2021

Conversation

abea
Copy link
Contributor

@abea abea commented Apr 20, 2021

This avoids false positives when we do things like use percentages in CSS/SCSS functions that will ultimately compile to something else or are part of the spec (e.g., hsla()).

So color: border-color: lighten(#000, 40%) would currently throw an error since we require px for border, but would not anymore with this change.

A new rule option PR'd by yours truly. stylelint/stylelint#5194 (may not be released yet).

@abea abea requested a review from gregvanbrug April 20, 2021 15:21
@abea abea self-assigned this Apr 20, 2021
Copy link
Member

@gregvanbrug gregvanbrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Nice!

@abea abea merged commit 337c086 into main Apr 20, 2021
@abea abea deleted the ignore-inside-functions branch April 20, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants