chore: fix broken test after merging #73

apollographql · Oct 16, 2023 · bf80011 · bf80011
1 parent d07b303
commit bf80011
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/language-server/errors/__tests__/NoMissingClientDirectives.test.ts b/src/language-server/errors/__tests__/NoMissingClientDirectives.test.ts
@@ -31,6 +31,7 @@ const a = /* GraphQL */ `
     isOnline
     me {
       name
+      foo # added field missing in service schema to ensure it doesn't throw, see https://github.com/apollographql/vscode-graphql/pull/73
       localUser @client {
         friends {
           isLiked

diff --git a/src/language-server/errors/validation.ts b/src/language-server/errors/validation.ts
@@ -175,7 +175,7 @@ export function NoMissingClientDirectives(context: ValidationContext) {
     const fieldDef = context.getFieldDef();
 
     // if we don't have a type to check then we can early return
-    if (!parentType || !fieldDef) return;
+    if (!parentType) return;
 
     // here we collect all of the fields on a type that are marked "local"
     const clientFields =
@@ -194,7 +194,7 @@ export function NoMissingClientDirectives(context: ValidationContext) {
         // fields are simple because we can just see if the name exists in the local fields
         // array on the parent type
         selectsClientFieldSet = Boolean(
-          clientFields && clientFields.includes(fieldDef!.name)
+          clientFields && clientFields.includes(fieldDef?.name || "")
         );
         message += `local field "${node.name.value}"`;
         break;