This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Prevent new data re-render attempts during an existing render #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a few small `QueryData` adjustments: - Replace the `forceUpdate` callback property name with `onNewData`, to make its use more clear. - Create a small public "has SSR started" helper utility that can be used by things like the `useQuery` hook to change its behavior depending on how it's being used.
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). In React Apollo, this warning can be triggered when nesting multiple components that leverage `useQuery`. To help avoid this, this commit ensures re-render requests to show new data are delayed until an effect hook is run to handle them (since we're then out of the render phase).
The latest `useReducer` API doesn't require an initial value.
JSONRice
approved these changes
Mar 27, 2020
benjamn
approved these changes
Mar 31, 2020
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Apr 3, 2020
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). In Apollo Client this warning can be triggered when nesting multiple components that leverage `useQuery`. To help avoid this, this commit ensures re-render requests to show new data are delayed until an effect hook is run to handle them (since we're then out of the render phase). These changes were originally implemented in apollographql/react-apollo#3902.
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Apr 3, 2020
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). In Apollo Client this warning can be triggered when nesting multiple components that leverage `useQuery`. To help avoid this, this commit ensures re-render requests to show new data are delayed until an effect hook is run to handle them (since we're then out of the render phase). These changes were originally implemented in apollographql/react-apollo#3902.
|
This creates a SSR regression when used by Next.js framework. lfades/next-with-apollo#126 similar regression (SSR) when upgrading from v4 to v5 (which uses Tested on UnlyEd/next-right-now#27 I don't think it's gonna be blocking (for me) but others could run into similar issue. If so, I believe following lfades/next-with-apollo#126 (comment) is the way to go, but I'm about to try and will confirm it. |
This was referenced Apr 3, 2020
hwillson
added a commit
that referenced
this pull request
Apr 13, 2020
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). PR #3902 addresses some of this, but doesn't quite catch all scenarios where this can occur. These changes take things further, ensuring that React Apollo components can't force update during a render phase.
hwillson
added a commit
that referenced
this pull request
Apr 13, 2020
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). PR #3902 addresses some of this, but doesn't quite catch all scenarios where this can occur. These changes take things further, ensuring that React Apollo components can't force update during a render phase.
hwillson
added a commit
that referenced
this pull request
Apr 14, 2020
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). PR #3902 addresses some of this, but doesn't quite catch all scenarios where this can occur. These changes take things further, ensuring that React Apollo components can't force update during a render phase.
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Apr 16, 2020
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). In Apollo Client this warning can be triggered when nesting multiple components that leverage `useQuery`. To help avoid this, this commit ensures re-render requests to show new data are delayed until an effect hook is run to handle them (since we're then out of the render phase). These changes were originally implemented in apollographql/react-apollo#3902.
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Apr 16, 2020
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). In Apollo Client this warning can be triggered when nesting multiple components that leverage `useQuery`. To help avoid this, this commit ensures re-render requests to show new data are delayed until an effect hook is run to handle them (since we're then out of the render phase). These changes were originally implemented in apollographql/react-apollo#3902.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). In React Apollo, this warning can be triggered when nesting multiple components that leverage
useQuery. To help avoid this, this PR ensures re-render requests to show new data are delayed until an effect hook is run to handle them (since we're then out of the render phase).Fixes #3863