Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Reemergence of #305: Generation of composition in spec'd form #559

Closed
wants to merge 3 commits into from
Closed

[WIP] Reemergence of #305: Generation of composition in spec'd form #559

wants to merge 3 commits into from

Conversation

abernix
Copy link
Member

@abernix abernix commented Mar 10, 2021 •
edited

This PR is basically a squash of everything in #305 that wasn't:

This has a temporary merge squash of the entirety of #326.

abernix and others added 2 commits March 10, 2021 15:20
@abernix
Composed schema in spec'd form.
0c3df98 
Co-authored-by: Ashi Krishnan <queerviolet@github.com>
@abernix
Temporary squash-merge of #326 (branch: qv/using). (👀 See comment!)
f61d560 
This commit is meant to be removed and replaced by a natural merge of `main`
into this branch after #326 lands or rebasing this on `main` after #326
lands.
@abernix abernix force-pushed the abernix/redux-cs-pr-wo-using branch from 549385b to f61d560 Compare March 10, 2021 18:35
@abernix abernix mentioned this pull request Mar 10, 2021
Closed
@abernix abernix changed the title [WIP] Reemergence of#305: Generation of composition in spec'd form [WIP] Reemergence of #305: Generation of composition in spec'd form Mar 10, 2021
Base automatically changed from abernix/harmonizer to main March 11, 2021 23:47
@abernix
Copy link
Member Author

abernix commented Apr 1, 2021

Superseded by #588 which finished the work — albeit in a different, but necessary way — and landed ultimately when it was merged into #622 (which was then reviewed).

@abernix abernix closed this Apr 1, 2021
@abernix abernix deleted the abernix/redux-cs-pr-wo-using branch April 1, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abernix