-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: context directives #2975
docs: context directives #2975
Conversation
|
✅ Deploy Preview for apollo-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clear additions! Just some suggestions for readability.
One overall suggestion: it might be nice to include a very sparse code snippet and/or diagram in the introductory section (#using-contexts-to-share-data-along-type-hierarchies). I think that can often help readers "get it" faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, meant to approve with my previous comments.
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
Docs for
@context
and@fromContext
directives.