Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: context directives #2975

Merged
merged 15 commits into from
May 30, 2024
Merged

docs: context directives #2975

merged 15 commits into from
May 30, 2024

Conversation

shorgi
Copy link
Contributor

@shorgi shorgi commented Apr 8, 2024

Docs for @context and @fromContext directives.

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: 3cd7217

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for apollo-federation-docs ready!

Name Link
🔨 Latest commit 3cd7217
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/6658c06a0611c20008e47300
😎 Deploy Preview https://deploy-preview-2975--apollo-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Apr 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@shorgi shorgi changed the title [WIP] docs: context directives docs: context directives May 16, 2024
@shorgi shorgi marked this pull request as ready for review May 16, 2024 00:02
@shorgi shorgi requested a review from a team as a code owner May 16, 2024 00:02
@shorgi shorgi requested a review from clenfest May 16, 2024 00:02
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/federated-directives.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/federated-directives.mdx Outdated Show resolved Hide resolved
docs/source/federation-versions.mdx Outdated Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/federated-directives.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/federated-directives.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clear additions! Just some suggestions for readability.

One overall suggestion: it might be nice to include a very sparse code snippet and/or diagram in the introductory section (#using-contexts-to-share-data-along-type-hierarchies). I think that can often help readers "get it" faster.

docs/source/entities-advanced.mdx Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/entities-advanced.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/federated-directives.mdx Outdated Show resolved Hide resolved
docs/source/federated-types/federated-directives.mdx Outdated Show resolved Hide resolved
docs/source/federation-versions.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, meant to approve with my previous comments.

shorgi and others added 3 commits May 30, 2024 09:36
Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com>
@shorgi shorgi requested a review from clenfest May 30, 2024 18:08
@shorgi shorgi merged commit 10737e2 into main May 30, 2024
19 checks passed
@shorgi shorgi deleted the eh/DOC-97/context-directive branch May 30, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants