Keep loadServiceDefinitions as protected

apollographql · Mar 5, 2021 · 01448e6 · 01448e6
1 parent ddca7eb
commit 01448e6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/gateway-js/CHANGELOG.md b/gateway-js/CHANGELOG.md
@@ -4,7 +4,7 @@
 
 > The changes noted within this `vNEXT` section have not been released yet.  New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development.  When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.
 
-- __BREAKING__: Make all `protected` gateway fields and methods `private`. To our knowledge, we've never encouraged subclassing the `ApolloGateway` class (which is the reason why one might choose `protected` over `private` in the first place). If you currently depend on the ability to override protected members of `ApolloGateway` please let us know. [PR #539](https://github.com/apollographql/federation/pull/539)
+- __BREAKING__: Make all `protected` gateway fields and methods `private` (except `loadServiceDefinitions`). If you currently depend on the ability to override any of these currently `protected` members of `ApolloGateway` please let us know. [PR #539](https://github.com/apollographql/federation/pull/539)
 
 ## v0.23.2
 

diff --git a/gateway-js/src/index.ts b/gateway-js/src/index.ts
@@ -718,7 +718,7 @@ export class ApolloGateway implements GraphQLService {
     }
   }
 
-  private async loadServiceDefinitions(
+  protected async loadServiceDefinitions(
     config: RemoteGatewayConfig | ManagedGatewayConfig,
   ): ReturnType<Experimental_UpdateServiceDefinitions> {
     if (isRemoteConfig(config)) {