Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve missing types "Boolean", "String" #1355

Merged
merged 4 commits into from Jun 27, 2019

Commits on Jun 17, 2019

  1. Resolve missing types

    A change to buildClientSchema removed some behavior that we
    depended on. Previously, with caching in place, basic types
    (Boolean, String, ...) were returned even if they didn't exist
    in typeMap. The "fix" was itself a breaking change, adding basic
    types that weren't previously added to the typeMap.
    
    Full discussion here: graphql/graphql-js@183ff32#r32971387
    
    This commit addresses a couple issues:
    1) Request the built in types from Engine
    2) Disallow versions of graphql that include the broken fix
    
    The broken fix causes a regression for service:push. During the
    broken fix (graphql@14.2.1-14.3.0), ALL built in types are included
    during buildClientSchema (even if they're not part of the schema).
    This causes a hash mismatch between the pushed schema and the
    schema hash that Apollo Server recognizes.
    trevor-scheer committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    71884d6 View commit details
    Browse the repository at this point in the history
  2. Update changelog

    trevor-scheer committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    78835e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Configuration menu
    Copy the full SHA
    26e3305 View commit details
    Browse the repository at this point in the history
  2. Fix version range

    Great catch @abernix, this fixes an issue with the version range
    previously wasn't parsed correctly by semver.
    trevor-scheer committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    363a01f View commit details
    Browse the repository at this point in the history