Fix client delay when subscription is terminated #7849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TylerBloom: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-server-docs pending review.Visit the deploys page to approve it
|
TylerBloom
force-pushed
the
fix-client-delay-on-subscription-close
branch
2 times, most recently
from
d872ebc
to
8292730
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
TylerBloom
force-pushed
the
fix-client-delay-on-subscription-close
branch
6 times, most recently
from
39c85a4
to
7890c28
Compare
TylerBloom
force-pushed
the
fix-client-delay-on-subscription-close
branch
from
7890c28
to
c7e514c
Compare
trevor-scheer
force-pushed
the
fix-client-delay-on-subscription-close
branch
from
860caf4
to
c7e514c
Compare
Merged
trevor-scheer
pushed a commit
that referenced
this pull request
Mar 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.10.2 ### Patch Changes - Updated dependencies \[[`c7e514c`](c7e514c)]: - @apollo/server@4.10.2 ## @apollo/server@4.10.2 ### Patch Changes - [#7849](#7849) [`c7e514c`](c7e514c) Thanks [@TylerBloom](https://github.com/TylerBloom)! - In the subscription callback server plugin, terminating a subscription now immediately closes the internal async generator. This avoids that generator existing after termination and until the next message is received. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #7842 .
When configured with an HTTP callback, a terminated subscription does not fully clean up its resources immediately. Namely, the async generator that the subscription object uses is not closed (i.e.
return()is not called). This means anything that is await-ing that promise will be waiting until the next message comes through the subscription.The desired behavior is that calling
terminateSubscriptionwill also end the async generator.To do this, the async generator is stored as a field in the subscription object, and its
return()method is called in theterminateSubscriptionmethod.