Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoke test, pin yargs-parser for now #6766

Merged
merged 1 commit into from Aug 4, 2022

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Aug 4, 2022

See: yargs/yargs-parser#452

We should remove the dependency altogether once this is resolved, as we don't actually depend on it.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

⚠️ No Changeset found

Latest commit: 3bdac56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 3bdac56
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/62ec2cc533aef20009375056
😎 Deploy Preview https://deploy-preview-6766--apollo-server-docs.netlify.app/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3bdac56:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I can never quite trust if these things will work when there are transitive deps involved but it looks like it passes. (idk if renovate will mess this up but if it does we can fix it)

@trevor-scheer
Copy link
Member Author

@glasser pretty sure renovate will try, we can reject the PR and it'll stop trying or fix via config. First option is probably fine since this likely won't be an issue for long.

@trevor-scheer trevor-scheer merged commit a92ef7a into version-4 Aug 4, 2022
@trevor-scheer trevor-scheer deleted the trevor/fix-smoke-test branch August 4, 2022 20:41
trevor-scheer added a commit that referenced this pull request Aug 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants