Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage reporting: fix TS declaration of fieldLevelInstrumentation #6763

Merged
merged 1 commit into from Aug 4, 2022
Merged

Usage reporting: fix TS declaration of fieldLevelInstrumentation #6763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ The version headers in this history reflect the versions of Apollo Server itself

## vNEXT

- _Nothing yet! Stay tuned._
- Fix the TypeScript declaration of the `fieldLevelInstrumentation` option to `ApolloServerPluginUsageReporting` to show that the function may return a number in addition to a boolean. This now matches the implementation and docs. [PR #6763](https://github.com/apollographql/apollo-server/pull/6763)

## v3.10.0

Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-core/src/plugin/usageReporting/options.ts
View file
Open in desktop
Expand Up @@ -120,7 +120,7 @@ export interface ApolloServerPluginUsageReportingOptions<TContext> {
| number
| ((
request: GraphQLRequestContextDidResolveOperation<TContext>,
) => Promise<boolean>);
) => Promise<number | boolean>);

/**
* This option allows you to choose if a particular request should be
Expand Down