Commits on Jun 24, 2022

1. enable eslint for one particular rule …

   So, Node requires generated ESM JS files need to have imports that end
   with `.js` (unless they are importing the root or declared export from a
   package... but for relative paths, this is a must). But we haven't quite
   figured out a way to get tsc to force us to do this... so if we mess it
   up, we only find out at runtime when trying to run a built ESM package.
   This doesn't even necessarily show up in our tests (Jest does its own
   thing a lot), and the new smoke-test doesn't cover all of our codebase.
   
   So we set up eslint with a particular rule that looks for this. As it
   happens, this rule doesn't check `import type`
   (import-js/eslint-plugin-import#2270) but
   fortunately `import type` doesn't matter to Node.
   
   We don't generally enable eslint: there are plenty of rules that we
   don't pass currently. We can consider adding some rules later as they
   are found to be valuable. For now we just run this one rule!

   

   glasser committed Jun 24, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 1de8fad
   • Browse repository at this point

   Copy the full SHA

   1de8fad View commit details

   Browse the repository at this point in the history