Glasser/package bundler #6556
Closed
Glasser/package bundler #6556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
force-pushed
the
glasser/package-bundler
branch
4 times, most recently
from
2f02d88
to
800d17d
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8aa0eee:
|
glasser
force-pushed
the
glasser/package-bundler
branch
from
800d17d
to
bc56d87
Compare
This reverts commit 0b58585. This leaves the fix of adding cors and body-parser to server's deps and leaves the removal of a TODO(AS4) about this. The build process for this package is completely different from a normal TS package, so keeping it together seems best. This seems like it'll make setting up ESM builds easier.
This would give us two things: publishing as ESM in addition to CJS, and the ability to have some symbols come from "deep imports" that aren't loaded automatically. It replaces some hacks like runtime requires in src/plugin/index.ts, and adds things like "you don't need to load express unless you actually import from the standalone directory". A directory with an index.ts in it is an entry point. The main rule is: you can import arbitrarily within your own entry point, but you can't do a "deep" import of a specific file or directory inside another entry point. Note that this means that any code that needs to be accessible from multiple entry points but not externally importable should be in an entry point whose name contains "internal" so that folks understand they shouldn't rely on its existence. This is coming close to working. Some issues I'm running into include: - TS directive emission isn't working because of the change to make packages/server/tsconfig.json only cover package.json. But maybe that can be reverted somehow. - How do we actually enforce that bad deep imports don't happen? - Is there still any point to ever running tsc emitting output? (Like for Jest maybe?) Should we ditch dist entirely? Not sure how though. - We're using the "copy and rewrite package.json into output dir" approach because that way the deep imports are `@apollo/server/standalone` not `@apollo/server/bundled/standalone`. I already found out how to get codesandbox CI to publish from the right directory but we have to do the same for changesets probably. - I did some refactors to make ApolloServer.ts use runtime import() to pull in the default-installed plugins but in CJS mode that still seems to include the plugin's code in the CJS file --- it won't actually be run (including its import of protobuf stuff) until needed at least. Let's figure out more next week.
glasser
force-pushed
the
glasser/package-bundler
branch
from
bc56d87
to
8aa0eee
Compare
|
Closing in favor of #6580 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.