Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usage reporting: don't throw errors if willResolveField is called "late" #6398

Merged
merged 1 commit into from Jun 4, 2022
Merged

usage reporting: don't throw errors if willResolveField is called "late" #6398

merged 1 commit into from Jun 4, 2022

Commits on Jun 4, 2022

  1. usage reporting: don't throw errors if willResolveField is called "late" 

    The comment explains this in detail. Basically, this "shouldn't happen"
error actually could happen. In theory, the times it could happen are
the exact times that the error itself would be swallowed rather than
becoming visible... but a graphql-js bug meant that sometimes they would
become visible anyway.

Fixes #4472.
    @glasser
    glasser committed Jun 4, 2022
    Copy the full SHA
    3fd72b1 View commit details
    Browse the repository at this point in the history