Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fastify): use scoped modules #6366

Merged
merged 1 commit into from May 5, 2022
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 28, 2022

The official plugins of fastify are now scoped, and the old names are deprecated. There should be no other breaking changes.

@netlify
Copy link

netlify bot commented Apr 28, 2022

👷 Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 55219f5

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 28, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 55219f5:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@glasser
Copy link
Member

glasser commented May 4, 2022

@SimenB Just to check: are the new packages fully backwards compatible with the old ones (eg, can you use the accepts and cors middlewares from the new packages with the same versions of Fastify as before?), or will users upgrading to a newer version of apollo-server-fastify need to upgrade Fastify as well?

(For what it's worth, we will be solving this problem in Apollo Server 4 by not trying to magically wrap these middleware in our own middleware and trusting that (with clearly documented examples) folks can use these middleware directly. We will also be decoupling the apollo-server-fastify release process from the Apollo Server core release process by providing a stable API between ApolloServer and web framework integrations and allowing active users of web frameworks like Fastify to maintain the integration with their expertise.)

@SimenB
Copy link
Contributor Author

SimenB commented May 4, 2022

Yeah, only breaking change is the rename 🙂

@glasser
Copy link
Member

glasser commented May 4, 2022

Great. Mind resolving the package-lock.json conflict? Rebasing should clear up the spell-check failure too.

@SimenB
Copy link
Contributor Author

SimenB commented May 5, 2022

@glasser done 🙂

@glasser
Copy link
Member

glasser commented May 5, 2022

Thanks! I'll put this out in apollo-server-fastify@3.6.8 today.

@glasser glasser merged commit 45f09fa into apollographql:main May 5, 2022
@SimenB SimenB deleted the fastify-scoped branch May 5, 2022 16:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants