apollo-server-core: Stop computing schema-derived data twice for non-gateway modes of operation #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachindshinde
force-pushed
the
sachin/stop-computing-schema-derived-data-twice
branch
from
06344fe
to
8850ed7
Compare
|
Looks great! I'll add a CHANGELOG entry. |
glasser
force-pushed
the
sachin/stop-computing-schema-derived-data-twice
branch
from
bb42a3c
to
4c9750b
Compare
…truction to start()
glasser
force-pushed
the
sachin/stop-computing-schema-derived-data-twice
branch
from
4c9750b
to
91c9df8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the schema-derived data provider in
SchemaManager.tscan be expensive. Currently,SchemaManagercomputes this twice for non-gateway modes of operation:SchemaManagerconstruction (as the caller expects errors to be caught early here).SchemaManager.start()(as we naively call it withinSchemaManager.processSchemaLoadOrUpdateEvent()).This PR:
SchemaManager.processSchemaLoadOrUpdateEvent()to accept an optionalschemaDerivedDataargument, which (if provided) causes it to store that and skip calling the schema-derived data provider.start().Fixes #5729 .