Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove access to process.env from hot code paths #5657

Merged
merged 7 commits into from
Sep 30, 2021
Merged

Remove access to process.env from hot code paths #5657

merged 7 commits into from
Sep 30, 2021

Commits on Sep 30, 2021

  1. Remove access to process.env from hot code paths

    @moberegger @glasser
    moberegger authored and glasser committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    0d7113c View commit details
    Browse the repository at this point in the history

  2. Add nodeEnv option to allow injecting node environment value

    @moberegger @glasser
    moberegger authored and glasser committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    8e1d2cc View commit details
    Browse the repository at this point in the history

  3. Accommodate tests with nodeEnv

    @moberegger @glasser
    moberegger authored and glasser committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    61be692 View commit details
    Browse the repository at this point in the history

  4. Use empty string to signify unset node environment

    @moberegger @glasser
    moberegger authored and glasser committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    34acf3f View commit details
    Browse the repository at this point in the history

  5. Add additional note about runtime changes to NODE_ENV

    @moberegger @glasser
    moberegger authored and glasser committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    15f7b30 View commit details
    Browse the repository at this point in the history

  6. Disallow explicit undefined for nodeEnv (missing is OK)

    @glasser
    glasser committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    e8b1f0d View commit details
    Browse the repository at this point in the history

  7. Docs and changelog

    @glasser
    glasser committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    ec9ea61 View commit details
    Browse the repository at this point in the history