feat(UserInputError): handle unhandled errors. #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I did tell you to work on release-3.0 but we merged it since then! I think we keep old release branches open in order to make cherry-picks on them, though maybe that's not helpful. Let me see if I can rebase your branch on top of main. |
required type & non-null errors handled.
glasser
force-pushed
the
feat/user-input-errors
branch
from
2110b3f
to
652e14a
Compare
|
OK, the rebasing worked. FWIW there's a related issue in graphql-js (graphql/graphql-js#3169) and this PR graphql/graphql-js#3193 would let us implement this in a less hacky way. But we'd need this code anyway for back-compat with current graphql-js releases. |
- Update comment to mention new checks and link to graphql-js issue - Reduce repetition in the logic (hopefully this increases rather than decreases clarity?) - prettier (required on main after rebasing) - CHANGELOG
|
I tweaked it a bit (eliminating some repeated code, which hopefully improves readability rather than making it worse, and some comments etc). Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It handles the unhandled user input errors mentioned in #5353 and closes #5353