lambda, cloud functions: change default path back to /
#5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Apollo Server 2, none of the serverless integrations paid much attention to the HTTP request path (other than for health checks). In AS3 we rewrote the Lambda and GCF integrations on top of `apollo-server-express` so they inherited ASE's behavior of only responding under `/graphql`. This doesn't make that much sense for serverless integrations, where paths are typically specified in the API Gateway (etc) configuration, and where functions typically do one thing. (Frankly, it doesn't make much sense for a default path to be built in to the framework integrations either rather than letting you specify the path when you attach the middleware to your app, but changing that in AS3 would have been one backwards-incompatible change too many). So we're going to change how AS3 works by saying that serverless integrations serve on `/`. This is technically incompatible with 3.0.0 but hey, it just came out, and this is more compatible with AS2. Improve some other docs while we're at it. Fixes #5472.
glasser
force-pushed
the
glasser/lambda-path
branch
from
b9bbd2d
to
2c3fc38
Compare
trevor-scheer
approved these changes
Jul 16, 2021
|
Fix released in 3.0.1. |
This was referenced Jul 16, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Apollo Server 2, none of the serverless integrations paid much
attention to the HTTP request path (other than for health checks). In
AS3 we rewrote the Lambda and GCF integrations on top of
apollo-server-expressso they inherited ASE's behavior of onlyresponding under
/graphql. This doesn't make that much sense forserverless integrations, where paths are typically specified in the API
Gateway (etc) configuration, and where functions typically do one thing.
(Frankly, it doesn't make much sense for a default path to be built in
to the framework integrations either rather than letting you specify the
path when you attach the middleware to your app, but changing that in
AS3 would have been one backwards-incompatible change too many).
So we're going to change how AS3 works by saying that serverless
integrations serve on
/. This is technically incompatible with 3.0.0but hey, it just came out, and this is more compatible with AS2.
Improve some other docs while we're at it.
Fixes #5462.