Update Express types files, allow further upgrades #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our versions for `@types/express` and `@types/express-serve-static-core` have gotten a bit out of date. They are already upgraded on `release-3.0` but that's not quite `latest` yet. Somehow despite the fact that neither `express` nor `serve-static` have had a new version in two years, the DefinitelyTyped packages for them keep getting backwards-incompatible changes. This is apparently helpful for some users who have upgraded some other packages. Because of how finicky these types are (eg specific `@types/express` versions depends on specific `@types/express-serve-static-core` versions without appropriate version dependencies between them) I do generally think it's best to depend on exact versions here. However I also don't want to have to make any more AS2 releases. So I'm making these into caret dependencies but don't intend to make a similar change on `release-3.0`. Fixes #5350.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our versions for
@types/expressand@types/express-serve-static-corehave gotten a bit out of date. They are already upgraded on
release-3.0but that's not quitelatestyet. Somehow despite thefact that neither
expressnorserve-statichave had a new version intwo years, the DefinitelyTyped packages for them keep getting
backwards-incompatible changes. This is apparently helpful for some
users who have upgraded some other packages.
Because of how finicky these types are (eg specific
@types/expressversions depends on specific
@types/express-serve-static-coreversionswithout appropriate version dependencies between them) I do generally
think it's best to depend on exact versions here. However I also don't
want to have to make any more AS2 releases. So I'm making these into
caret dependencies but don't intend to make a similar change on
release-3.0.Fixes #5350.