Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-server-lambda: Explicitly support payloadFormatVersion 2.0 #5098

Merged
merged 3 commits into from Apr 9, 2021

Conversation

glasser
Copy link
Member

@glasser glasser commented Apr 9, 2021

Fixes #5084.

The sooner we get out of the business of understanding Lambda event formats, the
better. But this fix should be good for now.

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended the parameterized approach offline, which is now implemented. This LGTM!

@trevor-scheer
Copy link
Member

Verdaccio is now? expecting Node 12, might need to update our container node v's to get Package tarballs to pass.

Fixes #5084.

The sooner we get out of the business of understanding Lambda event formats, the
better. But this fix should be good for now.
The default is "either is fine and you have to differentiate"
@glasser glasser merged commit 751dbf0 into release-2.23.0 Apr 9, 2021
@glasser glasser deleted the glasser/lambda-apig-2.0 branch April 9, 2021 19:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants