Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apollo-server-core: use UserInputError for variable coercion errors #5091

Merged
merged 4 commits into from Apr 8, 2021
Merged

apollo-server-core: use UserInputError for variable coercion errors #5091

merged 4 commits into from Apr 8, 2021

Commits on Apr 6, 2021

  1. apollo-server-core: use UserInputError for variable coercion errors 

    This particular error can be trivially triggered by clients, so it doesn't make
sense to use `INTERNAL_SERVER_ERROR` for it. It seems like a good fit for
`BAD_USER_INPUT`, which previously was only used if you explicitly throw a
`UserInputError` in your app.

Fixes #3498.
    @glasser
    glasser committed Apr 6, 2021
    Copy the full SHA
    551a5dd View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. figure out how to use the new constraint

    @glasser
    glasser committed Apr 7, 2021
    Copy the full SHA
    5cf5f8b View commit details
    Browse the repository at this point in the history

  2. changelog

    @glasser
    glasser committed Apr 7, 2021
    Copy the full SHA
    a8eac98 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. feedback

    @glasser
    glasser committed Apr 8, 2021
    Copy the full SHA
    4903375 View commit details
    Browse the repository at this point in the history