Release 2.22.2 #5073
Merged
Release 2.22.2 #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the backwards-compatibility method `willStart()` in v2.22.0 and v2.22.1 calls `_start`, which is illegal if the server is already started. But the server could have already been started for various reasons; specifically, for serverless frameworks the constructor would have called it (because that code is in `apollo-server-core` itself which is running the newer code). There are various ways to fix this, but the simplest way is just to make `willStart` into an unnecessarily async alias for `ensureStarting`. While the semantics aren't exactly identical, the overall effect is the same (because we now check that the server has started when operations actually run via `ensureStarted`, whereas before it was important for the integration itself to await the `willStart` promise).
- apollo-server-azure-functions@2.22.2-alpha.0 - apollo-server-cloud-functions@2.22.2-alpha.0 - apollo-server-cloudflare@2.22.2-alpha.0 - apollo-server-core@2.22.2-alpha.0 - apollo-server-express@2.22.2-alpha.0 - apollo-server-fastify@2.22.2-alpha.0 - apollo-server-hapi@2.22.2-alpha.0 - apollo-server-integration-testsuite@2.22.2-alpha.0 - apollo-server-koa@2.22.2-alpha.0 - apollo-server-lambda@2.22.2-alpha.0 - apollo-server-micro@2.22.2-alpha.0 - apollo-server-testing@2.22.2-alpha.0 - apollo-server@2.22.2-alpha.0
- apollo-server-azure-functions@2.22.2 - apollo-server-cloud-functions@2.22.2 - apollo-server-cloudflare@2.22.2 - apollo-server-core@2.22.2 - apollo-server-express@2.22.2 - apollo-server-fastify@2.22.2 - apollo-server-hapi@2.22.2 - apollo-server-integration-testsuite@2.22.2 - apollo-server-koa@2.22.2 - apollo-server-lambda@2.22.2 - apollo-server-micro@2.22.2 - apollo-server-testing@2.22.2 - apollo-server@2.22.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with release PRs in the past, this is a PR tracking a
release-x.y.zbranch for an upcoming release of Apollo Server. 馃檶 The version in the title of this PR should correspond to the appropriate branch.Check the appropriate milestone (to the right) for more details on what we hope to get into this release!
The intention of these release branches is to gather changes which are intended to land in a specific version (again, indicated by the subject of this PR). Release branches allow additional clarity into what is being staged, provide a forum for comments from the community pertaining to the release's stability, and to facilitate the creation of pre-releases (e.g.
alpha,beta,rc) without affecting themainbranch.PRs for new features might be opened against or re-targeted to this branch by the project maintainers. The
mainbranch may be periodically merged into this branch up until the point in time that this branch is being prepared for release. Depending on the size of the release, this may be once it reaches RC (release candidate) stage with an-rc.xrelease suffix. Some less substantial releases may be short-lived and may never have pre-release versions.When this version is officially released onto the
latestnpm tag, this PR will be merged intomain.